Merged
Conversation
aduth
approved these changes
Apr 12, 2022
Contributor
aduth
left a comment
There was a problem hiding this comment.
Looks good! 👍
Optional depending if you're feeling up to it, but would be good to have some test coverage here as well, to make sure that the flash is set when the form is invalid.
identity-idp/spec/controllers/idv/phone_controller_spec.rb
Lines 132 to 133 in 522f388
changelog: Bug Fixes, Identity Proofing, Fixed missing error message for invalid phone step submission- like non US number
35f97e9 to
2097630
Compare
aduth
approved these changes
Apr 13, 2022
Contributor
aduth
left a comment
There was a problem hiding this comment.
LGTM 👍 You can safely disregard the GitLab build failure.
specify exact error message we are expecting (us country code) Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LG-5225 Validation Errors not shown in IAL2
Why:
How:
Testing Instructions
<form>and addnovalidateScreenshot