Merged
Conversation
gsa-manish
force-pushed
the
LG-5927-document-analytic-events-no-9
branch
2 times, most recently
from
8f8afb5 to
d326fc5
Compare
app/services/analytics_events.rb
Outdated
Comment on lines
364
to
371
Contributor
There was a problem hiding this comment.
can you document the params? Running make lint_analytics_events will help highlight these
app/services/analytics_events.rb:366 idv_address_submitted success (undocumented)
app/services/analytics_events.rb:366 idv_address_submitted errors (undocumented)
app/services/analytics_events.rb:366 idv_address_submitted address_edited (undocumented)
app/services/analytics_events.rb:366 idv_address_submitted error_details (undocumented)
make: *** [lint_analytics_events] Error 1
d326fc5 to
50a5f65
Compare
changelog: Improvements, Analytics, Added analytic events (LG-5927)
gsa-manish
force-pushed
the
LG-5927-document-analytic-events-no-9
branch
from
50a5f65 to
7c0a58b
Compare
zachmargolis
approved these changes
Apr 12, 2022
Comment on lines
-129
to
-131
| IDV_BASIC_INFO_VISIT = 'IdV: basic info visited' | ||
| IDV_BASIC_INFO_SUBMITTED_FORM = 'IdV: basic info form submitted' | ||
| IDV_BASIC_INFO_SUBMITTED_VENDOR = 'IdV: basic info vendor submitted' |
Contributor
There was a problem hiding this comment.
just confirmed that these 3 events were removed in #3682 and seem to have been unused at that time, so I think there's no need to link these to current events, they're super out of date
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This documents analytic events related to this ticket: https://cm-jira.usa.gov/browse/LG-5927