Adapt StepIndicator script to custom element#6180
Merged
Conversation
**Why**: So it's more easily implemented in the context of a React component
[skip changelog]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: So it's more easily implemented in the context of a React component, with the expectation it will be used in ongoing work for the IdV API epic.
The current implementation of
StepIndicatoris "plain JavaScript", but written in a form which predates the use of custom elements. The previous implementation largely assumed the element would be rendered on a static page that is not long-lived, thus did not implement "tear down" behaviors common to custom elements and React usage.