Update password feature specs to target field by label#6096
Merged
Conversation
**Why*: So that our specs are testing a behavior matching the user's experience, and to guarantee that the fields are labelled correctly changelog: Internal, Tests, Improve feature tests to guarantee that fields are apporpiately labelled
aduth
changed the title
mitchellhenke
approved these changes
Mar 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from: #6081 (cherry-picks 2524f69, 354cd48, 45b11a0, c58289c)
Why: So that our specs are testing a behavior matching the user's real-world experience, and to guarantee that the fields are labelled correctly.
This supports #6081, where current specs assume specific element IDs, which will change as of #6081. The IDs themselves are unimportant for the purposes of the tests.
This only includes updates to feature specs relevant to password fields, not all fields.