Subset Public Sans to latin characters only#6094
Merged
Conversation
**Why**: So that users don't need to download glyph data for characters we won't be showing in the application.
mitchellhenke
approved these changes
Mar 18, 2022
6 tasks
changelog: Improvements, Optimization, Reduce size of font files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream: uswds/uswds#4542, uswds/uswds#4591
Slack context: https://gsa-tts.slack.com/archives/C0NGESUN5/p1645821094190849?thread_ts=1645133006.512749&cid=C0NGESUN5
Why: So that users don't need to download glyph data for characters we won't be showing in the application.
Reduces size of font data on home page by 35.7% (65.8kb to 42.3kb).
Generated using glyphhanger (
glyphhanger --LATIN --formats=woff2,woff --subset=*.ttf).Draft: For some reason, Roboto Mono font is not resolved correctly with Sprockets, despite the fact it should be referencing linked tree from manifest in same way Public Sans is referenced.Edit: Fixed in 9faf222.