Unrevert "Exclude core-js polyfills from ESM-capable browser bundles"#6075
Merged
Unrevert "Exclude core-js polyfills from ESM-capable browser bundles"#6075
Conversation
**Why**: So that we can have CI install dependencies in the same way as is expected in production, since jsbundling_rails will always install devDependencies with no option to opt-out.
aduth
changed the title
mitchellhenke
approved these changes
Mar 16, 2022
Contributor
Author
|
Verified expected failure in CircleCI, without fix included: |
**Why**: So that it's available in production build environments. changelog: Improvements, Optimization, Skip polyfill load behavior for modern browsers
mitchellhenke
approved these changes
Mar 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an unrevert of #6068.
It includes an extra commit c4b97b5 to try to force the failures seen in production build in our CI environment, by dropping the
jsbundling_railsgem.jsbundling_railswill always install devDependencies with no option to opt-out.This doesn't yet include the change from #6073, since I want to validate a build failure first.