Do not save additional PII to session when not needed#6072
Merged
mitchellhenke merged 1 commit intomainfrom Mar 16, 2022
Merged
Do not save additional PII to session when not needed#6072mitchellhenke merged 1 commit intomainfrom
mitchellhenke merged 1 commit intomainfrom
Conversation
mitchellhenke
force-pushed
the
mitchellhenke/do-not-store-pii-when-not-needed
branch
from
a538f74 to
1bb4a70
Compare
mitchellhenke
force-pushed
the
mitchellhenke/do-not-store-pii-when-not-needed
branch
from
1bb4a70 to
cc56b62
Compare
changelog: Internal, Performance, Do not save additional PII to session when not needed
mitchellhenke
force-pushed
the
mitchellhenke/do-not-store-pii-when-not-needed
branch
from
cc56b62 to
783173c
Compare
zachmargolis
approved these changes
Mar 16, 2022
mitchellhenke
force-pushed
the
mitchellhenke/do-not-store-pii-when-not-needed
branch
2 times, most recently
from
3d37333 to
783173c
Compare
mitchellhenke
deleted the
mitchellhenke/do-not-store-pii-when-not-needed
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In working on #6054, I noticed that we save the PII bundle in partial or whole states during the proofing process in places where it will never be read. This is not a significant change from a security or privacy perspective, except in that it reduces the copies of PII held in the session during the proofing process.
This PR addresses two of those instances. The first is when calling
extract_pii_from_doc, which puts the PII from doc auth into thepii_from_dockey inflow_session. If we are in the hybrid flow, we are in a separate and temporary session, andextract_pii_from_docwill be called in theLinkSentStepand stored properly there. With that, we don't need to save it twice.The other instance is in the transition from the DocAuthFlow to the address proofing step, where PII is moved from
user_session['idv/doc_auth']['pii_from_doc']touser_session['idv']['applicant']. The storage inuser_session['idv']['params']seems to be leftover from previous work, as I can't find a place it is used.