Merged
Conversation
aduth
reviewed
Feb 18, 2022
Contributor
There was a problem hiding this comment.
This file isn't currently being imported anywhere.
Contributor
Author
There was a problem hiding this comment.
Ah, it's created in #5944 - I'll be sure to wait for that to merge then resolve conflicts before merging mine.
.erb-lint.yml
Outdated
Comment on lines
61
to
62
Contributor
There was a problem hiding this comment.
Can we consolidate overlapping patterns on line 22-24?
aduth
reviewed
Feb 22, 2022
aduth
reviewed
Feb 22, 2022
Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
6c89781 to
3025f09
Compare
changelog: Improvements, Typography, Use design system for typography utilities
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: As a user, I expect that login.gov has a consistent visual style, and that my page load times are not prolonged by loading redundant CSS. As a developer, I expect that existing references to BassCSS module classes are replaced with equivalent USWDS or ad hoc alternatives, so that we can successfully migrate away from and eliminate our dependency on BassCSS.
Styles being removed:
All of the variables defined in the type-scale module of BassCSS were already in the idp stylesheets or unused. We can simply delete the inclusion of the BassCSS type-scale module.
The utility-typography classes map to the uswds classes as follows:
The BassCSS class
list-resetwas mapped tousa-list--unstyledwith no noticeable difference in layout:list-style: none;list-style-type:none;padding-left: 0;padding-left:0;margin-bottom:0;margin-top:0;The following two classes that didn't have a clear replacement and have been copied into the design-system-waiting-room: