SMS opt-in fixes

[zachmargolis]

Some follow-ups to #5894 based on testing we did today

• Update links to help at SP to be external (give them the little ➡️ and open in new tab)
• Update SmsSender to fail faster (don't retry OPT_OUT errors across regions)

[aduth]

👍

[aduth]

Whoops 😅 Thanks for fixing.

Interestingly, for reasons I cannot recall, we call it both things in the JSX implementation 🤔

identity-idp/app/javascript/packages/components/troubleshooting-options.jsx

Lines 34 to 36 in 12f214f

	{options.map(({ url, text, isExternal }) => (
	<li key={url}>
	<BlockLink url={url} isNewTab={isExternal}>

[aduth]

Should we consider the SMS opt-in configuration in deciding to fail fast or allow failover?

[zachmargolis]

Do you mean IdentityConfig.store.allow_sms_resubscribe? Or something else?

[aduth]

Do you mean IdentityConfig.store.allow_sms_resubscribe? Or something else?

Yes. In other words, should this logic only apply if we're allowing SMS resubscribe in the environment?

[zachmargolis]

My thinking is no, this logic should apply always, opt out means "don't send me SMS" so I think we don't want to failover or retry if we get that response.

We have older opt-out detecting logic that shows a flash error "you have opted out" (that isn't actionable), so this would result in that

[aduth]

Makes sense 👍

[aduth]

For considering PermanetnFailureError, should we limit it to the cases like what we're matching with this logic?

identity-idp/lib/telephony/pinpoint/sms_sender.rb

Lines 177 to 183 in 12f214f

	# Sometimes AWS Pinpoint returns PERMANENT_FAILURE with an "opted out" message
	# instead of an OPT_OUT error
	# @param [Aws::Pinpoint::Types::MessageResult] message_response_result
	def permanent_failure_opt_out?(message_response_result)
	message_response_result.delivery_status == 'PERMANENT_FAILURE' &&
	message_response_result.status_message&.include?('opted out')
	end

On the other hand, if it is a permanent failure, regardless the specific, maybe we don't want failover anyways.

[zachmargolis]

So... that logic you linked turns PERMANENT_FAILURE into OptOutError classes (because it seemed to be logically what it was representing)

I figure other permanent failures might include numbers that don't exist, or something so they seemed worth terminating on as well:

https://docs.aws.amazon.com/pinpoint/latest/apireference/apps-application-id-messages.html