Skip to content

Remove no-op line in AAMVA verification request#5911

Merged
zachmargolis merged 1 commit intomainfrom
margolis-remove-extra-line
Feb 3, 2022
Merged

Remove no-op line in AAMVA verification request#5911
zachmargolis merged 1 commit intomainfrom
margolis-remove-extra-line

Conversation

@zachmargolis
Copy link
Contributor

This line makes it look like we send the address to this vendor...but we do not

@aduth
Copy link
Contributor

aduth commented Feb 3, 2022

Would this cop have caught this? https://docs.rubocop.org/rubocop/cops_lint.html#lintuselessassignment

Copy link
Contributor

@solipet solipet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@zachmargolis
Copy link
Contributor Author

Would this cop have caught this? https://docs.rubocop.org/rubocop/cops_lint.html#lintuselessassignment

Survey says yes!

app/services/proofing/aamva/request/verification_request.rb:103:11: W: Lint/UselessAssignment: Useless assignment to variable - applicant_address. Did you mean applicant?
          applicant_address = applicant.address
          ^^^^^^^^^^^^^^^^^

But it flagged a bunch of other occurrences, so I filed LG-5809 so we can follow up later

@zachmargolis zachmargolis merged commit 41069d3 into main Feb 3, 2022
@zachmargolis zachmargolis deleted the margolis-remove-extra-line branch February 3, 2022 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants