Merged
Conversation
The smoke tests were unreliable so we replaced them with other kinds of monitoring to make the application still works.
Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
aduth
reviewed
Jan 31, 2022
| IdentityIdp/MailLaterLinter: | ||
| Enabled: true | ||
|
|
||
| IdentityIdp/TranslationLinter: |
Contributor
There was a problem hiding this comment.
We'll need to remove line 12 of this file as well.
Contributor
|
@theabrad CodeClimate's failure here looks incorrect (maintaining total coverage shouldn't be a problem if all this does is delete code), let me know if you'd like me to override CodeClimate with an admin merge |
zachmargolis
reviewed
Feb 1, 2022
|
|
||
| # Looks up the OIDC service provider for that environment, example key: MONITOR_INT_OIDC_SP_URL | ||
| def oidc_sp_url | ||
| ENV["MONITOR_#{monitor_env}_OIDC_SP_URL"] || (local? && '/test/oidc') |
Contributor
There was a problem hiding this comment.
oh wait this is the one place we use the test OIDC controller, the code coverage error may have been correct
Let's delete the OidcTestController and its route, views, etc. I think the SamlTestController is still used a little in other places
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The smoke tests were unreliable so we replaced them with other kinds of
monitoring to make the application still works.