Add the SAML remote logout endpoint to the metadata#5709
Conversation
orenyk
force-pushed
the
oyk-saml-metadata-logout
branch
2 times, most recently
from
2577b6e to
90c5fda
Compare
|
Blocked on #5710 |
Gemfile
Outdated
There was a problem hiding this comment.
TODO: replace once 18F/saml_idp#51 is merged and the tag is pushed
config/routes.rb
Outdated
There was a problem hiding this comment.
Removed the other actions since we really only support the POST binding and not the Redirect binding.
There was a problem hiding this comment.
This actually wasn't necessary to keep the tests passing so I also added request specs to ensure that we're only permitting POST requests.
spec/requests/saml_requests_spec.rb
Outdated
There was a problem hiding this comment.
Renamed this file, the first describe block is old.
orenyk
force-pushed
the
oyk-saml-metadata-logout
branch
2 times, most recently
from
e6bb64e to
ef6b8e9
Compare
|
Going to hold on merging this in until January, we'll want to have partners test it in |
orenyk
force-pushed
the
oyk-saml-metadata-logout
branch
2 times, most recently
from
58d7104 to
2e09a8a
Compare
|
Is this change still being tested? PR has been open over 2 months |
|
@zachmargolis whoops no, it just fell off my radar. We need some time to draft an email to partners letting them know and then I think I'd want to give them ~1 week in |
|
Can we close this and #5652 ? We can always bring it back if we need, but I don't feel like we should leave pull requests opened for months. |
orenyk
force-pushed
the
oyk-saml-metadata-logout
branch
4 times, most recently
from
a1d2085 to
724812d
Compare
**Why:** This needs to be configured as a separate item after upgrading the saml_idp gem. This commit also restricts remote logout requests to the POST HTTP method since that is the only binding we're supporting for that functionality (not HTTP-Redirect) changelog: Improvements, Authentication, Add SAML remote logout endpoint to metadata
orenyk
force-pushed
the
oyk-saml-metadata-logout
branch
from
724812d to
ab29f7b
Compare
4 participants
Why: This needs to be configured as a separate item after upgrading
the saml_idp gem.
This commit also restricts remote logout requests to the POST HTTP
method since that is the only binding we're supporting for that
functionality (not HTTP-Redirect)