LG-5373: Update troubleshooting options on the IAL2 Add your ID step

[aduth]

Why: As a user, I want to see options for which ID I can use to verify my identity, and tips for taking photos of my ID, so that I can get more help if I am having trouble adding photos of my ID without abandoning this step to go back to the service provider.

Screenshots:

Step	Mobile	Desktop
Document Capture
Review Issues

[zachmargolis]

LGTM

[zachmargolis]

would it make sense to do something like @see AppRootData or something to minimize duplication?

[aduth]

would it make sense to do something like @see AppRootData or something to minimize duplication?

Hm, yeah, I see the concern about the duplication. I think it might be nice if we could set up AppRootData to be an intersection type of all the different context values it's picking from, or vice-versa this context type a Pick<AppRootData, 'foo'|'bar'|'baz'>. One issue is that the dataset capitalization for the properties is different from the context capitalization, so the names don't line up exactly.

I think it could just be enough to do like you suggest with a @see, even if it's not "linked up" in a way that TypeScript/IDE/etc could follow, and avoid the extended property descriptions in all but the one canonical source.

[zachmargolis]

👍

[anniehirshman-gsa]

Screenshots LGTM!

Does the "More tips for adding photos of your ID" link lead to https://login.gov/help/verify-your-identity/how-to-add-images-of-your-state-issued-id/ ? Couldn't find it in the code but I may just be missing it

[aduth]

Does the "More tips for adding photos of your ID" link lead to https://login.gov/help/verify-your-identity/how-to-add-images-of-your-state-issued-id/ ? Couldn't find it in the code but I may just be missing it

Yep, it does 👍 This had existed already, so wasn't part of the changes here. But the relevant code is here:

identity-idp/app/services/marketing_site.rb

Lines 81 to 87 in b62ad69

	def self.help_document_capture_tips_url
	URI.join(
	BASE_URL,
	locale_segment,
	'help/verify-your-identity/how-to-add-images-of-your-state-issued-id/',
	).to_s
	end

[aduth]

I didn't notice an equivalent method was already available above:

identity-idp/app/services/marketing_site.rb

Lines 45 to 51 in b62ad69

	def self.help_idv_supported_documents_url
	URI.join(
	BASE_URL,
	locale_segment,
	'help/verify-your-identity/accepted-state-issued-identification/',
	).to_s
	end

I'll take care of this in #5662.