Skip to content

Respect the ForceAuthn attribute in SAML AuthnRequests#5644

Merged
orenyk merged 1 commit intomainfrom
oyk-forceauthn-fantastic
Nov 29, 2021
Merged

Respect the ForceAuthn attribute in SAML AuthnRequests#5644
orenyk merged 1 commit intomainfrom
oyk-forceauthn-fantastic

Conversation

@orenyk
Copy link
Contributor

@orenyk orenyk commented Nov 25, 2021

The SAML specification (section 3.4.1) includes an attribute
ForceAuthn for the AuthnRequest element that can be used by an SP to
require that a user be authenticated again, rather than relying on a
previous security context. This change allows the IdP to respect that
attribute and force authentication when an SP includes
ForceAuthn='true' in the SAML request.

Blocked on 18F/saml_idp#50

@orenyk orenyk requested a review from jmhooper November 25, 2021 01:38
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is mostly copied from the OIDC implementation of prompt=login, minus checking for SP handoff bounces (which I wasn't sure applied here).

@orenyk orenyk force-pushed the oyk-forceauthn-fantastic branch 2 times, most recently from 79f9389 to 55c2e2b Compare November 29, 2021 14:35
@orenyk orenyk requested a review from zachmargolis November 29, 2021 14:36
@orenyk orenyk force-pushed the oyk-forceauthn-fantastic branch from 55c2e2b to 04204f4 Compare November 29, 2021 15:14
Copy link
Contributor

@zachmargolis zachmargolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

The SAML specification (section 3.4.1) includes an attribute
`ForceAuthn` for the `AuthnRequest` element that can be used by an SP to
require that a user be authenticated again, rather than relying on a
previous security context. This change allows the IdP to respect that
attribute and force authentication when an SP includes
`ForceAuthn='true'` in the SAML request.
@orenyk orenyk force-pushed the oyk-forceauthn-fantastic branch from 04204f4 to 860f60f Compare November 29, 2021 15:57
@orenyk orenyk merged commit 64c0a7d into main Nov 29, 2021
@orenyk orenyk deleted the oyk-forceauthn-fantastic branch November 29, 2021 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants