Respect the ForceAuthn attribute in SAML AuthnRequests#5644
Merged
Conversation
orenyk
commented
Nov 25, 2021
Contributor
Author
There was a problem hiding this comment.
This is mostly copied from the OIDC implementation of prompt=login, minus checking for SP handoff bounces (which I wasn't sure applied here).
79f9389 to
55c2e2b
Compare
55c2e2b to
04204f4
Compare
The SAML specification (section 3.4.1) includes an attribute `ForceAuthn` for the `AuthnRequest` element that can be used by an SP to require that a user be authenticated again, rather than relying on a previous security context. This change allows the IdP to respect that attribute and force authentication when an SP includes `ForceAuthn='true'` in the SAML request.
04204f4 to
860f60f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SAML specification (section 3.4.1) includes an attribute
ForceAuthnfor theAuthnRequestelement that can be used by an SP torequire that a user be authenticated again, rather than relying on a
previous security context. This change allows the IdP to respect that
attribute and force authentication when an SP includes
ForceAuthn='true'in the SAML request.Blocked on 18F/saml_idp#50