Replace scss_lint with stylelint

[mitchellhenke]

scss_lint depends on ruby-sass, which reached it's end-of-life in March of 2019, so we should drop it. stylelint seemed to be the consensus replacement in past discussions and more generally in this space.

I started with the rule set in stylelint-config-recommended-scss as it was the least restrictive. stylelint-config-standard-scss is the other option should we want to include some of the rules there.

I am not confident that we have covered all of the old rules that scss_lint had though.

[zachmargolis]

YESSSSS next up remove sassc!!! 🔥 🔥 🔥

[mitchellhenke]

I don't know if my webpack skills are sufficient for the sprocket replacement journey, but I agree 😛

[mitchellhenke]

Also guessing we'll want to do the webpack 4 -> webpack 5 thing at some point too

[aduth]

Also guessing we'll want to do the webpack 4 -> webpack 5 thing at some point too

Still waiting on Webpacker v6 😩 (rc6 as of a few weeks ago)

[aduth]

Right now this doesn't seem to enforce much at all in terms of styling. For example, the following is perfectly valid:

.language-desktop-button{

  background-color:transparent; }

The other configuration you mentioned seems interesting as enforcing some common conventions. Did you try it out?

The 18F Engineering Guide codifies some of the styling we might want to aim for if we'd care to build out our own configuration.

I'm also fine to just get this in to unblock Ruby 3 and sort out the specific styling rules later / as we encounter them.