Update SimpleForm configuration to use design system error styling#5626
Merged
Update SimpleForm configuration to use design system error styling#5626
Conversation
**Why**: - For improved consistency of presentation of error messages in the application - Favoring design system over redundant, ad-hoc implementations - Unblocking new behaviors in #5619 where form-level `has-error` class error styling would take precedence over field-level validity state styling
anniehirshman-gsa
approved these changes
Nov 22, 2021
Contributor
anniehirshman-gsa
left a comment
anniehirshman-gsa
left a comment
There was a problem hiding this comment.
Screenshot LGTM too, thanks for catching this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from: #5619
Related upstream PR: 18F/identity-design-system#275
Why:
has-errorclass error styling would take precedence over field-level validity state stylingScreenshots:
Testing Instructions:
Notes:
For the most part, these error messages are not seen too often by end-users, due to client-side validation, both custom and browser native validation.