Merged
Conversation
- Very hot codepath, and 5 minutes of outdated data is likely acceptable
config/application.yml.default
Outdated
| aamva_sp_banlist_issuers: '[]' | ||
| aamva_verification_request_timeout: '5' | ||
| aamva_verification_url: https://example.org:12345/verification/url | ||
| all_redirect_uris_cache_duration_minutes: '5' |
Contributor
There was a problem hiding this comment.
Would you be open to reducing it to 2 minutes? Without a good way to expire, I'd rather err on the side of caution for now
Contributor
Author
There was a problem hiding this comment.
Suggested change
| all_redirect_uris_cache_duration_minutes: '5' | |
| all_redirect_uris_cache_duration_minutes: '2' |
Contributor
Author
There was a problem hiding this comment.
Done! I think if we wanted to expire the cache manually we could so something like this in the console:
Rails.cache.delete('all_service_provider_redirect_uris')but sure, switched to 2 minutes
Co-authored-by: Mitchell Henke <mitchell.henke@gsa.gov>
Contributor
Author
|
cc @jmhooper maybe a good candidate to include in RC 164 if we want to |
mitchellhenke
approved these changes
Nov 2, 2021
jmhooper
approved these changes
Nov 2, 2021
Contributor
|
Yeah, I can patch this one in! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a very hot codepath, so caching this helps us alleviate pressure on the DB