Page through S3 for smoke test emails#5571
Merged
zachmargolis merged 1 commit intomainfrom Nov 2, 2021
Merged
Conversation
mitchellhenke
requested review from
cantsin,
jmhooper,
loganmeetsworld,
pauldoomgov and
zachmargolis
mitchellhenke
force-pushed
the
mitchellhenke/fix-smokey
branch
2 times, most recently
from
2720549 to
7316e03
Compare
mitchellhenke
force-pushed
the
mitchellhenke/fix-smokey
branch
from
7316e03 to
e18ac8f
Compare
Contributor
|
Would it make sense to clear out all the old emails or something like that before running a test? That way we don't have an infinitely growing bucket? Another alternative: We could add a lifecycle policy to the emails to delete them after 24 hours (@pauldoomgov) |
Contributor
Author
The emails do self-delete once they’re used, but the lifecycle is pretty long right now (I think over a week?) |
Contributor
|
admin merging to get around codeclimate issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By only getting 100 unsorted objects from S3, there was always a chance the email we were looking for wouldn't be returned, so I've upped the number of objects returned to the maximum and added paging