Skip to content

Expand ERBLint exclusion glob patterns#5557

Merged
aduth merged 2 commits intomainfrom
aduth-expand-erblint-glob
Oct 29, 2021
Merged

Expand ERBLint exclusion glob patterns#5557
aduth merged 2 commits intomainfrom
aduth-expand-erblint-glob

Conversation

@aduth
Copy link
Contributor

@aduth aduth commented Oct 29, 2021

Why:

  • More straight-forward to fix individual files
  • Avoid allowing new files to be exempt by virtue of matching glob pattern
  • Some files matching these patterns are already correct (e.g. app/views/users/verify_personal_key/throttled.html.erb)
make lint_erb | grep "In file:" | sed 's/^In file: /*\//' | sed 's/:.*//' | uniq | sort

aduth added 2 commits October 29, 2021 09:14
**Why**:

* More straight-forward to fix individual files
* Avoid allowing new files to be exempt by virtue of matching glob pattern
* Some files matching these patterns are already correct (e.g. `app/views/users/verify_personal_key/throttled.html.erb` )
Copy link
Contributor

@mitchellhenke mitchellhenke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼 👍🏼 👍🏼

@aduth aduth merged commit 8386525 into main Oct 29, 2021
@aduth aduth deleted the aduth-expand-erblint-glob branch October 29, 2021 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants