LG-5231: Remove tooltip from personal key input field #5536
Merged
Conversation
jmdembe
changed the title
jmdembe
force-pushed
the
jd-LG-5231-remove-personal-key-tooltip
branch
5 times, most recently
from
f54cbd4 to
4df956b
Compare
Contributor
There was a problem hiding this comment.
I know we had the number 19 hardcoded before... is there a way to avoid hardcoding this magic number?
Contributor
Author
There was a problem hiding this comment.
I can make 19 a variable
Contributor
There was a problem hiding this comment.
Meh it's probably not worth it because that doesn't address how we came up with 19 as a length
jmdembe
force-pushed
the
jd-LG-5231-remove-personal-key-tooltip
branch
2 times, most recently
from
1e6bfd2 to
8273e52
Compare
jmdembe
force-pushed
the
jd-LG-5231-remove-personal-key-tooltip
branch
from
d686aac to
66108bd
Compare
jmdembe
force-pushed
the
jd-LG-5231-remove-personal-key-tooltip
branch
from
b1390ec to
8492acf
Compare
mdiarra3
approved these changes
Oct 26, 2021
aduth
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the tooltip from the personal key field
Why: So we do not have to rely on the browser to show an error message if the personal key input field is empty