Skip to content

[LG-5273] Disable brittle validation for IntegrationUsages #5524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
orenyk merged 1 commit into from
Oct 20, 2021
Merged

[LG-5273] Disable brittle validation for IntegrationUsages #5524

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion app/models/agreements/integration_usage.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,9 @@ class Agreements::IntegrationUsage < ApplicationRecord
validates :integration, presence: true
validates :integration_id, uniqueness: { scope: :iaa_order_id }

validate :integration_and_order_have_same_account
# DISABLED 2021-10-20 due to unforeseen edge case where we transfer an
# integration from one account to another
# validate :integration_and_order_have_same_account

private

Expand Down
2 changes: 1 addition & 1 deletion spec/models/agreements/integration_usage_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
it { is_expected.to validate_presence_of(:integration) }
it { is_expected.to validate_uniqueness_of(:integration_id).scoped_to(:iaa_order_id) }

it 'validates that the IAA Order and Integration belong to the same account' do
xit 'validates that the IAA Order and Integration belong to the same account' do
subject.iaa_order = create(:iaa_order)
expect(subject).not_to be_valid
end
Expand Down