Merged
Conversation
zachmargolis
force-pushed
the
margolis-remove-job-runs
branch
2 times, most recently
from
d527ebf to
b135320
Compare
Merged
stevegsa
approved these changes
Oct 18, 2021
zachmargolis
commented
Oct 19, 2021
Comment on lines
9
to
+14
| if defined?(Rails::Console) | ||
| Rails.logger.info 'job_configurations: console detected, skipping schedule' | ||
| elsif IdentityConfig.store.ruby_workers_cron_enabled | ||
| else | ||
| # rubocop:disable Metrics/BlockLength | ||
| Rails.application.configure do | ||
| config.good_job.cron = all_configs.transform_values { |config| config.fetch(:good_job) } | ||
| config.good_job.cron = { |
Contributor
Author
|
admin merging because of code coverage issue, there's less code overall now and it's all config |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We still need to enable cron jobs in prod and let it sit for a few days, so this is a do not merge. But I'm ready!!
Follow-up PRs: