-
Notifications
You must be signed in to change notification settings - Fork 166
Interpolate "Login.gov" everywhere (LG-4886) #5498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
38 commits
Select commit
Hold shift + click to select a range
eff5a1c
WIP: interpolate logingov
zachmargolis f322f6e
more
zachmargolis 0bb5e61
moar
zachmargolis 25d2999
moar
zachmargolis 5f8efbd
rename stuffs
zachmargolis f77244d
spec message
zachmargolis 003ce7e
wip
zachmargolis 2b068ef
lints
zachmargolis 1c1d7de
fix specs
zachmargolis 0588fb5
Re-translate strings to be interpolated
zachmargolis 9aeb619
some fixes
zachmargolis ffc25d3
more fixessss
zachmargolis 3f38cdb
lints
zachmargolis 5f37004
i think we did it
zachmargolis 6dc4595
fix more tests
zachmargolis 61feb13
update interpolation in specs
zachmargolis 3a9d386
Change %{app} => %{app_name} for consistency
zachmargolis 3491ff1
normalize yaml
zachmargolis a826a53
add missing subject interpolation
zachmargolis 003f30c
lint
zachmargolis fdf066d
javascript
zachmargolis 8bee669
nother spec
zachmargolis 6e8b3b5
subject tests
zachmargolis aa2dee1
js fixes
zachmargolis 1bbee5e
html safe interpolation
zachmargolis 3fe7c7f
Merge branch 'main' into margolis-lg-4886-interpolate-logingov
zachmargolis f07862d
Remove some newlines that snuck in there
zachmargolis cbe59e4
Update spec to reference constant
zachmargolis cf38a02
Update app/views/account_reset/confirm_delete_account/show.html.erb
zachmargolis ffc15ad
add another interp
zachmargolis c601b7c
Remove unused interp argument
zachmargolis ed82f1e
Revert "Remove unused interp argument"
zachmargolis d9aa159
Make specs yell when %{} does not match args
zachmargolis 1138ff0
fix extra/missing interp arguments
zachmargolis a583ff9
lints
zachmargolis f95ee2c
add a few more known args
zachmargolis a825382
remove "extra_keys" check, that was too sensitive
zachmargolis d23bc76
remove i18n.t overrides for specs, too picky
zachmargolis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| import { createContext } from 'react'; | ||
|
|
||
| /** | ||
| * @typedef AppContext | ||
| * | ||
| * @prop {string} appName name of the application (probably Login.gov) | ||
| */ | ||
|
|
||
| const AppContext = createContext(/** @type {AppContext} */ ({ appName: '' })); | ||
|
|
||
| AppContext.displayName = 'AppContext'; | ||
|
|
||
| export default AppContext; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 3 additions & 3 deletions
6
app/services/user_alerts/alert_user_about_account_verified.rb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.