Skip to content

LG-5187:Implement Improvements to focus and increase pixel size #5486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jmdembe merged 5 commits into from
Oct 14, 2021
Merged

LG-5187:Implement Improvements to focus and increase pixel size #5486

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
13e9ac2
increase focus and outline offset; solid border when upload is succes…
jmdembe Oct 8, 2021
ad49c2d
fix linter errors
jmdembe Oct 8, 2021
04d0a42
update focus for file input box
jmdembe Oct 12, 2021
6956612
Update app/assets/stylesheets/components/_file-input.scss
jmdembe Oct 13, 2021
0e6b9a5
refine focus for file input box for when a file is uploaded
jmdembe Oct 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions app/assets/stylesheets/components/_file-input.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,6 @@
border-color: color('primary-dark');
}
}

.usa-file-input__input:focus {
outline-offset: 3px;
}
}

.usa-form-group--error .usa-file-input .usa-file-input__target {
Expand Down Expand Up @@ -75,3 +71,12 @@
width: 100%;
}
}

.usa-file-input__input:not([disabled]):focus {
outline: 3px solid $blue;
outline-offset: 6px;
Copy link
Copy Markdown
Contributor

@aduth aduth Oct 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this offset account for the border of the input itself? For a field with a value, it seems to be much bigger an offset:

image

I can see how we'd need a big offset for the chunkier 3px border, but should it be reduced when it's the thinner border when a value is assigned? Like 4px or 5px?

}

.usa-file-input--has-value .usa-file-input__input:not([disabled]):focus {
outline-offset: 4px;
}