LG-4944: track whether the user edits their address or not

app/controllers/idv/address_controller.rb

@@ -12,6 +12,7 @@ def new
     def update
       form_result = idv_form.submit(profile_params)
       analytics.track_event(Analytics::IDV_ADDRESS_SUBMITTED, form_result.to_h)
+      capture_address_edited(form_result)
       if form_result.success?
         success
       else
@@ -28,10 +29,7 @@ def confirm_pii_from_doc
     end
 
     def idv_form
-      Idv::AddressForm.new(
-        user: current_user,
-        previous_params: idv_session.previous_profile_step_params,
-      )
+      Idv::AddressForm.new(@pii)
     end
 
     def success
@@ -48,5 +46,10 @@ def failure
     def profile_params
       params.require(:idv_form).permit(Idv::AddressForm::ATTRIBUTES)
     end
+
+    def capture_address_edited(result)
+      address_edited = result.to_h[:address_edited]
+      user_session['idv/doc_auth']['address_edited'] = address_edited if address_edited
+    end
   end
 end

app/forms/idv/address_form.rb

@@ -11,8 +11,9 @@ def self.model_name
       ActiveModel::Name.new(self, nil, 'Address')
     end
 
-    def initialize(user)
-      @user = user
+    def initialize(pii)
+      @pii = pii
+      @address_edited = false
     end
 
     def submit(params)
@@ -21,7 +22,10 @@ def submit(params)
       FormResponse.new(
         success: valid?,
         errors: errors,
-        extra: { pii_like_keypaths: [[:errors, :zipcode ], [:error_details, :zipcode]] },
+        extra: {
+          address_edited: @address_edited,
+          pii_like_keypaths: [[:errors, :zipcode ], [:error_details, :zipcode]],
+        },
       )
     end
 
@@ -31,6 +35,9 @@ def consume_params(params)
       params.each do |key, value|
         raise_invalid_address_parameter_error(key) unless ATTRIBUTES.include?(key.to_sym)
         send("#{key}=", value)
+        if send(key) != @pii[key] && (send(key).present? || @pii[key].present?)
+          @address_edited = true
+        end
       end
     end
 

app/services/idv/steps/verify_wait_step_show.rb

@@ -31,7 +31,10 @@ def async_state_done(current_async_state)
         form_response = idv_result_to_form_response(
           idv_result: current_async_state.result,
           state: flow_session[:pii_from_doc][:state],
-          extra: { pii_like_keypaths: [[:errors, :ssn]] },
+          extra: {
+            address_edited: !!flow_session['address_edited'],
+            pii_like_keypaths: [[:errors, :ssn]],
+          },
         )
 
         if form_response.success?

spec/features/idv/doc_auth/verify_step_spec.rb

@@ -27,6 +27,8 @@
   end
 
   it 'proceeds to the next page upon confirmation' do
+    allow_any_instance_of(ApplicationController).to receive(:analytics).and_return(fake_analytics)
+
     click_idv_continue
 
     expect(page).to have_current_path(idv_phone_path)
@@ -35,6 +37,10 @@
     expect(user.proofing_component.resolution_check).to eq('lexis_nexis')
     expect(user.proofing_component.source_check).to eq('aamva')
     expect(DocAuthLog.find_by(user_id: user.id).aamva).to eq(true)
+    expect(fake_analytics).to have_logged_event(
+      'IdV: doc auth optional verify_wait submitted',
+      address_edited: false,
+    )
   end
 
   it 'proceeds to address page prepopulated with defaults if the user clicks change address' do
@@ -46,6 +52,21 @@
     expect(page).to have_selector("input[value='59010']")
   end
 
+  it 'tracks when the user edits their address' do
+    allow_any_instance_of(ApplicationController).to receive(:analytics).and_return(fake_analytics)
+
+    click_link t('doc_auth.buttons.change_address')
+    fill_out_address_form_ok
+    click_idv_continue # address form
+
+    click_idv_continue
+
+    expect(fake_analytics).to have_logged_event(
+      'IdV: doc auth optional verify_wait submitted',
+      address_edited: true,
+    )
+  end
+
   it 'proceeds to the ssn page if the user clicks change ssn and allows user to go back' do
     click_button t('doc_auth.buttons.change_ssn')