Merged
Conversation
**Why**: To improve page load speed by reducing CSS bundle size, to eliminate developer confusion by choice of border styling, to improve developer experience by reducing SASS compilation times, and to standardize on design system styles. Reference for removal: https://github.com/basscss/basscss-sass/blob/v3.0.0/_borders.scss
aduth
commented
Sep 14, 2021
| .btn-border { | ||
| border-color: $border-color; | ||
| border-radius: $border-radius-lg; | ||
| border-radius: 8px; |
Contributor
Author
There was a problem hiding this comment.
This is going away in #5279 so I don't care so much about inlining the value.
zachmargolis
approved these changes
Sep 14, 2021
Contributor
zachmargolis
left a comment
zachmargolis
left a comment
There was a problem hiding this comment.
LGTM! do we care to add these removed classes to the ERBlint?
mitchellhenke
approved these changes
Sep 14, 2021
Contributor
Author
Yeah, I suppose I can add the patterns just to have extra assurance the classes aren't in use anymore. I'm increasingly wanting to remove the DeprecatedClass linting altogether though, since the value vs. effort isn't feeling very compelling anymore. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: To improve page load speed by reducing CSS bundle size, to eliminate developer confusion by choice of border styling, to improve developer experience by reducing SASS compilation times, and to standardize on design system styles.
Reference for removal: https://github.com/basscss/basscss-sass/blob/v3.0.0/_borders.scss
Implementation notes:
border-top, etc. are still valid utility classes of USWDS (source), with the difference in implementation being that BassCSS applies a color. Since we always accompany our usage of these classes with aborder-primary-light, no extra changes are needed.