Merged
Conversation
**Why**: To migrate off of the Readthis gem without colliding with the same keys
zachmargolis
commented
Aug 27, 2021
| @@ -7,5 +7,8 @@ | |||
| end | |||
|
|
|||
| REDIS_POOL = ConnectionPool.new(size: 10) do | |||
Contributor
Author
There was a problem hiding this comment.
today this is only used in the (unlaunched in prod) RISC rate limiting, and that data is keys that expire every ~60 seconds, so there is no risk of data loss updating this now
Contributor
Author
|
A few notes on my plan to migrate off of readthis: #5337 (comment) |
mitchellhenke
approved these changes
Aug 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: To migrate off of the Readthis gem without
colliding with the same keys