Try to avoid 500s caused by database race conditions

[mitchellhenke]

find_or_create_by is subject to race conditions if a unique query runs more than one at a time

create_or_find_by flips it so it attempts to create first, and if a unique constraint database exception occurs, it then does a select to get that row.

Example New Relic error

[zachmargolis]

LGTM!!! I can't believe these are not the same method 🤦

Might be worth adding a lint/cop for to help us do the right thing?

[mitchellhenke]

Might be worth adding a lint/cop for to help us do the right thing?

I was hoping the same, but the confounder right now is Throttle uses find_or_create_by, but does not have a unique index backing it. Switching it to create_or_find_by ends up creating a bunch of identical throttles, so we'd need to allow some usage for now.

[zachmargolis]

Might be worth adding a lint/cop for to help us do the right thing?

I was hoping the same, but the confounder right now is Throttle uses find_or_create_by, but does not have a unique index backing it. Switching it to create_or_find_by ends up creating a bunch of identical throttles, so we'd need to allow some usage for now.

🤦 whoops, just realized neither of the indexes are unique my b