Rate limit RISC ruby workers by destination (LG-4973)#5335
Rate limit RISC ruby workers by destination (LG-4973)#5335zachmargolis merged 5 commits intomainfrom
Conversation
app/jobs/risc_delivery_job.rb
Outdated
There was a problem hiding this comment.
ok so, the attempts: :unlimited is a little spicy, but my thinking is, we want to do our best to deliver these notifications, and rate limiting is us throttling ourselves, and not even giving them an attempt to be down? So I think our limit would keep us to a fixed throughput, which is constant load for us but maybe not so bad?
Open to feedback on this
There was a problem hiding this comment.
Well with the exponential delay, I think that the red line would go down more over time as the requests get spaced out more but same same
There was a problem hiding this comment.
I think we should have a maximum. We don't have visibility into why we aren't able to complete the request, and it creates a growing queue that limits the potentially successful events from going out. I'd rather start on the conservative side of "best effort" and improve what our "best" is as we go.
There was a problem hiding this comment.
Ok, how does a maximum of 10 sound?
There was a problem hiding this comment.
if it's 2^10 seconds (~17 minutes) that sounds good to me 🙂
zachmargolis
force-pushed
the
margolis-rate-limit-risc
branch
from
27fa159 to
a8e7dcc
Compare
- Also make timeout retries count explicit
2 participants
Builds on #5333