Merged
Conversation
jmdembe
force-pushed
the
jd-LG-4940-address-parsing-issues
branch
from
528d23d to
9d07eb0
Compare
aduth
approved these changes
Aug 20, 2021
app/javascript/app/pw-toggle.js
Outdated
Contributor
There was a problem hiding this comment.
For what it's worth, these are being replaced altogether as part of #5279. But I can address conflicts in my branch if this is merged first.
jmdembe
force-pushed
the
jd-LG-4940-address-parsing-issues
branch
from
9d07eb0 to
e92af2e
Compare
mdiarra3
approved these changes
Aug 23, 2021
jmdembe
force-pushed
the
jd-LG-4940-address-parsing-issues
branch
from
d5a7331 to
0aa51db
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ticket addresses parsing issues that were found during the audit of the IAL2 flow.
Why: Parsing is all about writing a clean code “HTML, CSS OR JavaScript” in a manner that is understood by browsers & assistive technologies. If the code is not written according to standards it can break the user experience of the application & assistive technology users will have a lot of problems to deal with. (Source)
Note: the only warning that is not addressed is
Attribute aria-required is unnecessary for elements that have attribute required.. My theory on is that if an input field is marked as required, thearia-requiredattribute is also created. If anyone has any thoughts on this theory, I am open to hearing any discussion about this.