Allow idv/confirmations_controller #show and #download out of order (LG-4847)#5230
Merged
zachmargolis merged 2 commits intomainfrom Jul 23, 2021
Merged
Conversation
zachmargolis
commented
Jul 22, 2021
Comment on lines
-74
to
-75
| user_session[:personal_key] = @code | ||
| idv_session.personal_key = nil |
Contributor
Author
There was a problem hiding this comment.
it seemed like Idv::Session#personal_key was being written to a bunch but never actually used?
I just decided to remove it to simplify, since we already store the data across requests in user_session
aduth
approved these changes
Jul 23, 2021
| else | ||
| head :bad_request | ||
| end | ||
| analytics.track_event(Analytics::IDV_DOWNLOAD_PERSONAL_KEY, success: code.present?) |
Contributor
There was a problem hiding this comment.
This logging was introduced in #5215, I assume to be able to find the sorts of issues we were seeing then. If we're addressing that and assuming code will always be set, do we still need the logging? Or at least the success property?
Contributor
Author
There was a problem hiding this comment.
We still want the event to help us track when people do download, but I guess now the success would help us detect some not-expected degenerate cases where random key generation fails
mitchellhenke
approved these changes
Jul 23, 2021
zachmargolis
added a commit
that referenced
this pull request
Sep 22, 2021
zachmargolis
added a commit
that referenced
this pull request
Sep 22, 2021
zachmargolis
added a commit
that referenced
this pull request
Sep 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.