Async doc auth analytics (LG-4488)#5067
Conversation
mitchellhenke
requested review from
aduth,
amathews-fs,
stevegsa and
zachmargolis
aduth
left a comment
aduth
left a comment
There was a problem hiding this comment.
Didn't have the time to do a full review here, but dropping a couple thoughts from first glance. Will review in the morning, if none beat me to it.
aduth
left a comment
aduth
left a comment
There was a problem hiding this comment.
Left a few thoughts, but it appears to work well in my testing 👍
There was a problem hiding this comment.
In the Idv::ApiImageUploadForm#validate_pii_from_doc equivalent, we merge extra_attributes. I don't know that remaining attempts is an especially important value here, though it may be worth being consistent regardless (even if consistently omitting the detail).
There was a problem hiding this comment.
added in a0e722a
I tested that user_id was logged in both normal and hybrid flow, so I didn't include that from extra_attributes.
mitchellhenke
force-pushed
the
mitchellhenke/async-doc-auth-analytics-lg-4488
branch
2 times, most recently
from
f405452 to
548681c
Compare
mitchellhenke
force-pushed
the
mitchellhenke/async-doc-auth-analytics-lg-4488
branch
from
a0e722a to
02bd520
Compare
2 participants
Adds the
IDV_DOC_AUTH_SUBMITTED_IMAGE_UPLOAD_FORMandIDV_DOC_AUTH_SUBMITTED_PII_VALIDATIONevents to the async document step flow. Moves theIDV_DOC_AUTH_SUBMITTED_IMAGE_UPLOAD_VENDORevent to be in the proofing job, and to pass the browser and client image metadata to the job for inclusion in the event data.