Merged
Conversation
amoose
force-pushed
the
amos/fix/initial_readme_and_license
branch
from
8852ee9 to
2720f6b
Compare
qmanderson1
added a commit
that referenced
this pull request
Feb 7, 2017
Changed #5 for grammar and from tu to usted.
Merged
night-jellyfish
pushed a commit
that referenced
this pull request
Apr 9, 2024
* changelog: Internal, Doc Auth, add analytics event for tracking unexpected sdk error ## 🎫 Ticket [LG-12920](https://cm-jira.usa.gov/browse/LG-12920) ## 🛠 Summary of changes Implements the `setUnexpectedErrorCallback` method from [Acuant setup instructions (step #5)](https://github.com/Acuant/JavascriptWebSDKV11?tab=readme-ov-file#setup). We wanted to implement this now in case it gives us useful messages about the black screen issues in [LG-12671](https://cm-jira.usa.gov/browse/LG-12671). ## 📜 Testing Plan I could not find a way to test this or to trigger it locally. It needs to be an error that happens after SDK load but before initialization. We would like to have a test for it, or at least have a way to trigger it manually, but we don't believe we have a way to do that.
zachmargolis
pushed a commit
that referenced
this pull request
Sep 20, 2024
* Update to Ruby 2.3.1
* Convert specs to RSpec 3.5.4 syntax with Transpec
This conversion is done by Transpec 3.2.2 with the following command:
transpec
* 83 conversions
from: obj.should
to: expect(obj).to
* 60 conversions
from: == expected
to: eq(expected)
* 16 conversions
from: it { should ... }
to: it { is_expected.to ... }
* 8 conversions
from: obj.should_not
to: expect(obj).not_to
* 3 conversions
from: obj.stub(:message => value)
to: allow(obj).to receive_messages(:message => value)
* 1 conversion
from: it { should_not ... }
to: it { is_expected.not_to ... }
* 1 conversion
from: obj.stub(:message)
to: allow(obj).to receive(:message)
For more details: https://github.com/yujinakayama/transpec#supported-conversions
* Do not test ruby < 2.0
* remove deprecated dependency
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.