Merged
Conversation
aduth
reviewed
Apr 27, 2021
Contributor
aduth
left a comment
aduth
left a comment
There was a problem hiding this comment.
🎉 This will be a nice win for maintainability to remove.
aduth
added a commit
that referenced
this pull request
Apr 28, 2021
**Why**: This partial existed to reduce code duplication and to handle special options specific to the recovery flow, which was removed in #4980. Since it's only used in one place, and since it doesn't need to support "extra options", change to render inline.
aduth
added a commit
that referenced
this pull request
Apr 28, 2021
**Why**: This partial existed to reduce code duplication and to handle special options specific to the recovery flow, which was removed in #4980. Since it's only used in one place, and since it doesn't need to support "extra options", change to render inline.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
How: Subsequent PR will drop account_recovery_requests