LG-4392: Set Acuant canvas width as HTML attribute#4936
Merged
Conversation
**Why**: Because as of Acuant SDK v11.4.4, the SDK now sets width and height attributes based on a desirable aspect ratio (see "setDimens' function, Acuant SDK v11.4.4 L828). Inline styles conflict with these attributes because they are of higher specificity, which can cause unexpected behavior.
mitchellhenke
approved these changes
Apr 20, 2021
Contributor
Author
|
Holding off on merge 'til deciding if we're moving forward with the upgrade for now. See: #4943 |
Contributor
Author
|
On second thought, I'll merge this and include the merge commit in the revert pull request. |
amathews-fs
pushed a commit
that referenced
this pull request
Apr 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to: #4929
Why: As of Acuant SDK v11.4.4, the SDK now sets width and height attributes based on a desirable aspect ratio (see
setDimensfunction, Acuant SDK v11.4.4 L828). Inline styles conflict with these attributes because they are of higher specificity, which can cause unexpected behavior.Relevant documentation: https://github.com/Acuant/JavascriptWebSDKV11/tree/master/SimpleHTMLApp#start-live-capture