Skip to content

simplify pinpoint config #4839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mitchellhenke merged 1 commit into from
Mar 26, 2021
Merged

simplify pinpoint config #4839

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions config/application.yml.default
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,14 +101,8 @@ password_max_attempts: '3'
personal_key_retired: 'true'
phone_format_e164_opt_out_list: '[]'
pii_lock_timeout_in_minutes: '30'
pinpoint_sms_application_id:
pinpoint_sms_credential_role_arn:
pinpoint_sms_longcode_pool:
pinpoint_sms_region:
pinpoint_sms_shortcode:
pinpoint_voice_credential_role_arn:
pinpoint_voice_longcode_pool:
pinpoint_voice_region:
pinpoint_sms_configs: '[]'
pinpoint_voice_configs: '[]'
poll_rate_for_verify_in_seconds: '3'
proofer_mock_fallback: 'true'
proofing_send_partial_dob: 'false'
Expand Down
45 changes: 11 additions & 34 deletions config/initializers/telephony.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,47 +7,24 @@
Logger.new('log/telephony.log', level: :info)
end

if AppConfig.env.pinpoint_sms_configs.present?
JSON.parse(AppConfig.env.pinpoint_sms_configs || '[]').each do |sms_json_config|
c.pinpoint.add_sms_config do |sms|
sms.application_id = sms_json_config['application_id']
sms.region = sms_json_config['region']
sms.shortcode = sms_json_config['shortcode']
sms.credential_role_arn = sms_json_config['credential_role_arn']
if sms_json_config['credential_role_arn'].present?
sms.credential_role_session_name = Socket.gethostname
end
end
end
else
JSON.parse(AppConfig.env.pinpoint_sms_configs).each do |sms_json_config|
c.pinpoint.add_sms_config do |sms|
sms.region = AppConfig.env.pinpoint_sms_region
sms.application_id = AppConfig.env.pinpoint_sms_application_id
sms.shortcode = AppConfig.env.pinpoint_sms_shortcode
sms.credential_role_arn = AppConfig.env.pinpoint_sms_credential_role_arn
if AppConfig.env.pinpoint_sms_credential_role_arn.present?
sms.application_id = sms_json_config['application_id']
sms.region = sms_json_config['region']
sms.shortcode = sms_json_config['shortcode']
sms.credential_role_arn = sms_json_config['credential_role_arn']
if sms_json_config['credential_role_arn'].present?
sms.credential_role_session_name = Socket.gethostname
end
end
end

if AppConfig.env.pinpoint_voice_configs.present?
JSON.parse(AppConfig.env.pinpoint_voice_configs || '[]').each do |voice_json_config|
c.pinpoint.add_voice_config do |voice|
voice.region = voice_json_config['region']
voice.longcode_pool = voice_json_config['longcode_pool'] || []
voice.credential_role_arn = voice_json_config['credential_role_arn']
if voice_json_config['credential_role_arn'].present?
voice.credential_role_session_name = Socket.gethostname
end
end
end
else
JSON.parse(AppConfig.env.pinpoint_voice_configs).each do |voice_json_config|
c.pinpoint.add_voice_config do |voice|
voice.region = AppConfig.env.pinpoint_voice_region
voice.longcode_pool = JSON.parse(AppConfig.env.pinpoint_voice_longcode_pool || '[]')
voice.credential_role_arn = AppConfig.env.pinpoint_voice_credential_role_arn
if AppConfig.env.pinpoint_voice_credential_role_arn.present?
voice.region = voice_json_config['region']
voice.longcode_pool = voice_json_config['longcode_pool'] || []
voice.credential_role_arn = voice_json_config['credential_role_arn']
if voice_json_config['credential_role_arn'].present?
voice.credential_role_session_name = Socket.gethostname
end
end
Expand Down