Fix double-click error by reverting phone redirect fix#4722
Merged
zachmargolis merged 2 commits intomasterfrom Feb 25, 2021
Merged
Fix double-click error by reverting phone redirect fix#4722zachmargolis merged 2 commits intomasterfrom
zachmargolis merged 2 commits intomasterfrom
Conversation
Contributor
zachmargolis
commented
Feb 25, 2021
zachmargolis
commented
- adds a regression spec for issue we've observed causing 500s in prod (6084636)
- reverts Fix adding new phone number redirects to SP (LG-3784) #4660, which fixes this issue for now (but brings that bug back)
stevegsa
approved these changes
Feb 25, 2021
mitchellhenke
approved these changes
Feb 25, 2021
Contributor
mitchellhenke
left a comment
mitchellhenke
left a comment
There was a problem hiding this comment.
I vote keep the handoff class merge in there 😛
Contributor
Author
Same, I just don't have the energy to wait for another build |
Contributor
Author
Also if we didn't squash commits...we could just revert some of it and keep that big 🤔 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.