Skip to content

Skip devDependencies in deploy build step#4696

Closed
aduth wants to merge 1 commit intomasterfrom
aduth-install-prod-deployed-env
Closed

Skip devDependencies in deploy build step#4696
aduth wants to merge 1 commit intomasterfrom
aduth-install-prod-deployed-env

Conversation

@aduth
Copy link
Contributor

@aduth aduth commented Feb 22, 2021

Why: We should not need to install devDependencies in deployed environments, as they should not expect to be needed for build or for runtime. This may improve build time by reducing dependency preparation time, and avoid imposing requirements on deployed environments for dependencies which are only relevant for development (see #4680).

Status: Currently for testing. May not be mergeable, pending:

  1. Need to audit existing dependencies to make sure they're categorized correctly
  2. May want to change how we build and deploy IDP artifacts (assets, etc). See related Slack discussion.
  3. May want to consider setting up CircleCI to match this behavior except when running JavaScript tests, which may require breaking up the existing build task.

**Why**: We should not need to install devDependencies in deployed environments, as they should not expect to be needed for build or for runtime. This may improve build time by reducing dependency preparation time, and avoid imposing requirements on deployed environments for dependencies which are only relevant for development (see #4680).
@aduth
Copy link
Contributor Author

aduth commented Feb 26, 2021

I think we only need an active branch for testing, so I'll close the pull request and keep the branch alive. If this looks promising, we can reopen the pull request.

@aduth aduth closed this Feb 26, 2021
@aduth aduth deleted the aduth-install-prod-deployed-env branch September 9, 2021 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant