Skip to content

do not raise exception on null byte in OIDC token code (LG-4155) #4641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mitchellhenke merged 1 commit into from
Feb 3, 2021
Merged

do not raise exception on null byte in OIDC token code (LG-4155) #4641

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/forms/openid_connect_token_form.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ def url_options
attr_reader :identity

def find_identity_with_code
return if code.blank?
return if code.blank? || code.include?("\x00")

session_expiration = AppConfig.env.session_timeout_in_minutes.to_i.minutes.ago
@identity = Identity.where(session_uuid: code).
Expand Down
9 changes: 9 additions & 0 deletions spec/forms/openid_connect_token_form_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,15 @@
end
end

context 'the code has a null byte' do
let(:code) { "\x00code"}

it 'is invalid' do
expect(valid?).to eq(false)
expect(form.errors[:code]).to include(t('openid_connect.token.errors.invalid_code'))
end
end

context 'code has expired' do
before { identity.update(updated_at: 1.day.ago) }

Expand Down