Merged
Conversation
**Why**: So that `make lint_erb` matches all files (276), not just some (101).
Leverage internal glob pattern
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously: #4599
Why: So that
make lint_erbmatches all files (276), not just some (101).I don't recall this having been an issue in my initial implementation.
A few alternatives exist which all solve the problem:
bundle exec erblint --lint-allI think the original issue may be caused by differences in shell glob expansion when run through Make? The existing
bundle execcall works fine when run standalone.In any case, the current proposal is based on a bit of sleuthing to determine that the file argument passing supports directories, and by passing directories uses the default glob pattern (source).