Check phone type for VOIP, log carrier (LG-4102, LG-4100)#4601
Merged
zachmargolis merged 10 commits intomasterfrom Jan 22, 2021
Merged
Check phone type for VOIP, log carrier (LG-4102, LG-4100)#4601zachmargolis merged 10 commits intomasterfrom
zachmargolis merged 10 commits intomasterfrom
Conversation
Contributor
|
Did we decide we want to prevent VOIP numbers from signing up entirely? I thought we were only planning on blocking them at AAL2? |
|
I missed it. is this PR a prototype to test the integration with the service that'll be validating numbers are not VOIP or is this meant to be full prod implementation? agree with @jmhooper though that we do want to impose this restriction when AAL2 is explicitly requested, or implicitly required because they are signing into IAL2. |
Contributor
|
@porta-antiporta, @zachmargolis, @TiffanyAndrews, and I synced up on this. We determined we are going to go with this approach where we are disallowing VOIP numbers on phone setup. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copy is pending, here's what it looks like when we do a field error with some made-up copy
I had some fun with temporary copy