Skip to content

Check phone type for VOIP, log carrier (LG-4102, LG-4100)#4601

Merged
zachmargolis merged 10 commits intomasterfrom
margolis-block-voip
Jan 22, 2021
Merged

Check phone type for VOIP, log carrier (LG-4102, LG-4100)#4601
zachmargolis merged 10 commits intomasterfrom
margolis-block-voip

Conversation

@zachmargolis
Copy link
Contributor

Copy is pending, here's what it looks like when we do a field error with some made-up copy

Screen Shot 2021-01-21 at 2 21 09 PM

I had some fun with temporary copy

@jmhooper
Copy link
Contributor

Did we decide we want to prevent VOIP numbers from signing up entirely? I thought we were only planning on blocking them at AAL2?

@porta-antiporta
Copy link

porta-antiporta commented Jan 22, 2021

I missed it. is this PR a prototype to test the integration with the service that'll be validating numbers are not VOIP or is this meant to be full prod implementation?

agree with @jmhooper though that we do want to impose this restriction when AAL2 is explicitly requested, or implicitly required because they are signing into IAL2.

@jmhooper
Copy link
Contributor

@porta-antiporta, @zachmargolis, @TiffanyAndrews, and I synced up on this. We determined we are going to go with this approach where we are disallowing VOIP numbers on phone setup.

Copy link
Contributor

@stevegsa stevegsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@zachmargolis zachmargolis merged commit 1a7f874 into master Jan 22, 2021
@zachmargolis zachmargolis deleted the margolis-block-voip branch January 22, 2021 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants