Move document capture CSS to main stylesheet bundle#4587
Merged
Conversation
**Why**: Temporary solution to address issue of nondeterministic hashes in deployed environments.
aduth
commented
Jan 14, 2021
| window.LoginGov.assets = <%= raw asset_keys.map { |key| [key, asset_path(key)] }.to_h.to_json %>; | ||
| <% end %> | ||
| <%= javascript_packs_tag_once 'document-capture' %> | ||
| <%= stylesheet_packs_with_chunks_tag 'document-capture' %> |
Contributor
Author
There was a problem hiding this comment.
This will conflict with the stages/prod branch because we switched from stylesheet_pack_tag to stylesheet_packs_with_chunks_tag in #4553, merged this morning. In both cases, it's just a matter of removing the Webpacker pack import of the stylesheet.
Contributor
Author
There was a problem hiding this comment.
See branch aduth-remove-webpacker-sass-prod based on stages/prod, specifically can cherry-pick 99b26f1 onto stages/prod.
mitchellhenke
approved these changes
Jan 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: Temporary solution to address issue of nondeterministic hashes in deployed environments.