Deploy RC 126 to Staging

.circleci/config.yml

@@ -152,6 +152,7 @@ jobs:
           command: |
             mkdir /tmp/test-results
             ./cc-test-reporter before-build
+            bin/rails zeitwerk:check
 
             bundle exec rake knapsack:rspec
             yarn test
@@ -182,9 +183,8 @@ jobs:
             yarn run lint
             yarn run typecheck
             bundle exec rubocop
-            bundle exec slim-lint app/views
             make check_asset_strings
-            ./bin/webpack && yarn es5-safe
+            NODE_ENV=production ./bin/webpack && yarn es5-safe
   build-release-container:
     working_directory: ~/identity-idp
     docker:
@@ -233,7 +233,9 @@ jobs:
     environment:
       MONITOR_ENV: STAGING
     steps:
-      - checkout
+      - jq/install
+      - checkout-deployed-sha:
+          sha_url: https://idp.staging.login.gov/api/deploy.json
       - bundle-yarn-install
       - run:
           name: "Smoke tests"
@@ -302,7 +304,7 @@ workflows:
           filters:
             branches:
               only:
-                - stages/staging
+                - master
     jobs:
       - smoketest-staging
 

.codeclimate.yml

@@ -32,11 +32,6 @@ checks:
 plugins:
   brakeman:
     enabled: true
-    exclude_patterns:
-    # Excluding User Flows tools since these are not loaded
-    # except when explicitly called from the User Flow rake tasks
-    - 'lib/user_flow_exporter.rb'
-    - 'lib/rspec/formatters/user_flow_formatter.rb'
   bundler-audit:
     enabled: true
   coffeelint:
@@ -53,8 +48,6 @@ plugins:
     - 'node_modules/**/*'
     - 'db/schema.rb'
     - 'app/forms/password_form.rb'
-    - 'lib/user_flow_exporter.rb'
-    - 'lib/rspec/formatters/user_flow_formatter.rb'
   fixme:
     enabled: true
     exclude_patterns:
@@ -81,9 +74,7 @@ exclude_patterns:
   - 'db/schema.rb'
   - 'node_modules/'
   - 'lib/proofer_mocks/'
-  - 'lib/rspec/formatters/user_flow_formatter.rb'
   - 'lib/tasks/create_test_accounts.rb'
-  - 'lib/user_flow_exporter.rb'
   - 'scripts/load_testing/'
   - 'tmp/'
   - 'config/initializers/jwt.rb'

.eslintrc

@@ -25,6 +25,7 @@
     "indent": "off",
     "max-classes-per-file": "off",
     "newline-per-chained-call": "off",
+    "no-empty": ["error", { "allowEmptyCatch": true }],
     "no-param-reassign": ["off", "never"],
     "no-confusing-arrow": "off",
     "no-plusplus": "off",

.rubocop.yml

@@ -10,30 +10,18 @@ AllCops:
     - 'bin/**/*'
     - 'db/migrate/*'
     - 'db/schema.rb'
-    - 'lib/rspec/user_flow_formatter.rb'
     - 'lib/tasks/create_test_accounts.rb'
-    - 'lib/user_flow_exporter.rb'
     - 'node_modules/**/*'
     - 'tmp/**/*'
     - 'vendor/**/*'
   TargetRubyVersion: 2.6
-  TargetRailsVersion: 5.2
+  TargetRailsVersion: 6.0
   UseCache: true
+  DisabledByDefault: true
 
 Rails:
   Enabled: true
 
-Metrics/AbcSize:
-  Description: A calculated magnitude based on number of assignments, branches, and
-    conditions.
-  Enabled: false
-  Max: 15
-  Exclude:
-  - spec/**/*
-
-Metrics/CyclomaticComplexity:
-  Enabled: false
-
 Metrics/BlockLength:
   CountComments: false  # count full line comments?
   Enabled: true
@@ -47,12 +35,6 @@ Metrics/BlockLength:
     - 'config/routes.rb'
     - 'spec/**/*.rb'
 
-Metrics/ClassLength:
-  Description: Avoid classes longer than 100 lines of code.
-  Enabled: false
-  CountComments: false
-  Max: 100
-
 Layout/LineLength:
   Description: Limit lines to 100 characters.
   StyleGuide: https://github.com/bbatsov/ruby-style-guide#80-character-limits
@@ -65,16 +47,6 @@ Layout/LineLength:
   Exclude:
     - 'config/routes.rb'
 
-Metrics/MethodLength:
-  Description: Avoid methods longer than 15 lines of code.
-  StyleGuide: https://github.com/bbatsov/ruby-style-guide#short-methods
-  Enabled: false
-  CountComments: false
-  Max: 15
-  Exclude:
-  - 'db/migrate/*'
-  - spec/**/*
-
 Metrics/ModuleLength:
   CountComments: false
   Max: 200
@@ -93,6 +65,9 @@ Naming/VariableName:
 Rails/FilePath:
   Enabled: false
 
+Rails/ApplicationMailer:
+  Enabled: false
+
 Rails/HttpPositionalArguments:
   Description: 'Use keyword arguments instead of positional arguments in http method calls.'
   Enabled: true
@@ -150,13 +125,6 @@ Style/AndOr:
   - always
   - conditionals
 
-Style/Documentation:
-  Description: Document classes and non-namespace modules.
-  Enabled: false
-  Exclude:
-    - 'spec/**/*'
-    - 'test/**/*'
-
 Layout/DotPosition:
   Description: Checks the position of the dot in multi-line method calls.
   StyleGuide: https://github.com/bbatsov/ruby-style-guide#consistent-multi-line-chains
@@ -165,9 +133,6 @@ Layout/DotPosition:
   - leading
   - trailing
 
-Style/DoubleNegation:
-  Enabled: false
-
 # Warn on empty else statements
 # empty - warn only on empty else
 # nil - warn on else with nil in it
@@ -187,12 +152,6 @@ Layout/ExtraSpacing:
   # When true, forces the alignment of = in assignments on consecutive lines.
   ForceEqualSignAlignment: false
 
-Style/FrozenStringLiteralComment:
-  Description: >-
-                 Add the frozen_string_literal comment to the top of files
-                 to help transition from Ruby 2.3.0 to Ruby 3.0.
-  Enabled: false
-
 Style/IfUnlessModifier:
   Description: Favor modifier if/unless usage when you have a single-line body.
   StyleGuide: https://github.com/bbatsov/ruby-style-guide#if-as-a-modifier
@@ -250,9 +209,6 @@ Style/StringLiterals:
   - double_quotes
   ConsistentQuotesInMultiline: true
 
-Style/RegexpLiteral:
-  Enabled: false
-
 Style/TrailingCommaInArguments:
   # If `comma`, the cop requires a comma after the last argument, but only for
   # parenthesized method calls where each argument is on its own line.
@@ -289,42 +245,6 @@ Style/TrailingCommaInHashLiteral:
 Naming/MethodParameterName:
   MinNameLength: 2
 
-Style/ExpandPathArguments:
-  Enabled: false
-
-Style/FormatStringToken:
-  Enabled: false
-
-Style/SingleLineBlockParams:
-  Enabled: false
-
-Layout/EmptyLineAfterGuardClause:
-  Enabled: false
-
-Naming/MemoizedInstanceVariableName:
-  Enabled: false
-
-Naming/RescuedExceptionsVariableName:
-  Enabled: false
-
-Style/HashEachMethods:
-  Enabled: false
-
-Style/HashTransformKeys:
-  Enabled: false
-
-Style/HashTransformValues:
-  Enabled: false
-
-Lint/SuppressedException:
-  Enabled: false
-
-Lint/SendWithMixinArgument:
-  Enabled: false
-
-Layout/EmptyLinesAroundAttributeAccessor:
-  Enabled: false
-
 Layout/SpaceAroundMethodCallOperator:
   Enabled: true
 
@@ -337,24 +257,9 @@ Lint/MixedRegexpCaptureTypes:
 Lint/RaiseException:
   Enabled: true
 
-Lint/StructNewOverride:
-  Enabled: false
-
-Style/ExponentialNotation:
-  Enabled: false
-
 Style/RedundantRegexpCharacterClass:
   Enabled: true
 
-Style/RedundantRegexpEscape:
-  Enabled: false
-
-Style/SlicingWithRange:
-  Enabled: false
-
-Rails/ApplicationMailer:
-  Enabled: false
-
 Lint/BinaryOperatorWithIdenticalOperands:
   Enabled: true
 
@@ -367,9 +272,6 @@ Lint/DuplicateRescueException:
 Lint/FloatComparison:
   Enabled: true
 
-Lint/MissingSuper:
-  Enabled: false
-
 Lint/OutOfRangeRegexpRef:
   Enabled: true
 
@@ -388,9 +290,6 @@ Lint/SelfAssignment:
 Lint/TopLevelReturnWithArgument:
   Enabled: true
 
-Style/GlobalStdStream:
-  Enabled: false
-
 Style/RedundantAssignment:
   Enabled: true
 
@@ -400,42 +299,6 @@ Style/RedundantFetchBlock:
 Style/RedundantFileExtensionInRequire:
   Enabled: true
 
-Lint/EmptyConditionalBody:
-  Enabled: false
-
-Lint/UnreachableLoop:
-  Enabled: false
-
-Style/AccessorGrouping:
-  Enabled: false
-
-Style/ArrayCoercion:
-  Enabled: false
-
-Style/BisectedAttrAccessor:
-  Enabled: false
-
-Style/CaseLikeIf:
-  Enabled: false
-
-Style/ExplicitBlockArgument:
-  Enabled: false
-
-Style/HashAsLastArrayItem:
-  Enabled: false
-
-Style/HashLikeCase:
-  Enabled: false
-
-Style/OptionalBooleanParameter:
-  Enabled: false
-
-Style/SingleArgumentDig:
-  Enabled: false
-
-Style/StringConcatenation:
-  Enabled: false
-
 Style/MultilineWhenThen:
   Enabled: true
 
@@ -448,30 +311,12 @@ Lint/DuplicateRequire:
 Lint/TrailingCommaInAttributeDeclaration:
   Enabled: true
 
-Lint/EmptyFile:
-  Enabled: false
-
-Lint/UselessMethodDefinition:
-  Enabled: false
-
-Style/CombinableLoops:
-  Enabled: false
-
-Style/RedundantSelfAssignment:
-  Enabled: false
-
-Style/SoleNestedConditional:
-  Enabled: false
-
 Lint/UselessTimes:
   Enabled: true
 
 Layout/BeginEndAlignment:
   Enabled: true
 
-Lint/ConstantDefinitionInBlock:
-  Enabled: false
-
 Lint/IdentityComparison:
   Enabled: true
 
@@ -480,3 +325,12 @@ Bundler/DuplicatedGem:
 
 Naming/BinaryOperatorParameterName:
   Enabled: true
+
+Lint/DuplicateRegexpCharacterClassElement:
+  Enabled: true
+
+Style/ArgumentsForwarding:
+  Enabled: true
+
+Style/NilLambda:
+  Enabled: true

CONTRIBUTING.md

@@ -1,22 +1,13 @@
 ## Welcome!
 
-We're so glad you're thinking about contributing to an 18F open source project!
-If you're unsure about anything, just ask — or submit the issue or pull request
-anyway. The worst that can happen is you'll be politely asked to change
-something. We love all friendly contributions.
+We’re so glad you’re thinking about contributing to a Technology Transformation Services (TTS) open source project! If you’re unsure about anything, just ask — or submit your issue or pull request anyway. The worst that can happen is we’ll politely ask you to change something. We appreciate all friendly contributions.
 
-We want to ensure a welcoming environment for all of our projects. Our staff
-follow the [18F Code of Conduct][code] and all contributors should do the same.
+TTS is committed to building a safe, welcoming, harassment-free culture for everyone. We expect everyone on the TTS team and everyone within TTS spaces, including contributors to our projects, to follow the [TTS Code of Conduct](https://github.com/18F/code-of-conduct/blob/master/code-of-conduct.md).
 
-We encourage you to read this project's CONTRIBUTING policy (you are here), its
-[LICENSE](LICENSE.md), and its [README](README.md).
+We encourage you to read this project’s CONTRIBUTING policy (you are here), its [LICENSE](LICENSE.md), [README](README.md)
 
-If you have any questions or want to read more, check out the
-[18F Open Source Policy GitHub repository][os-policy], or just
-[shoot us an email](mailto:18f@gsa.gov).
+If you have any questions or want to read more, check out the [18F Open Source Policy GitHub repository]( https://github.com/18f/open-source-policy), or [send us an email](mailto:18f@gsa.gov).
 
-[code]: https://github.com/18F/code-of-conduct/blob/master/code-of-conduct.md
-[os-policy]: https://github.com/18f/open-source-policy
 
 ## Pull request guidelines