add analytic events for lambda callbacks#4561
Merged
mitchellhenke merged 1 commit intomasterfrom Jan 5, 2021
Merged
Conversation
zachmargolis
approved these changes
Jan 5, 2021
| if dcs | ||
| analytics.track_event( | ||
| Analytics::LAMBDA_RESULT_ADDRESS_PROOF_RESULT, | ||
| result: address_result_parameter, |
Contributor
There was a problem hiding this comment.
are we trying to log the whole result? or just the result ID?
Contributor
There was a problem hiding this comment.
Do we want to guard this on env so we don't create too many extra log events?
Contributor
Author
There was a problem hiding this comment.
I think these could good to have even beyond smoke test issues. I don't think they'd be too numerous since they'd be limited to proofing
We do log full responses, at least for errors, during phone verification from what I can see in cloudwatch. There isn't any PII in the lambda callbacks with the exception of doc auth, which should be explicitly excluding it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
further debugging for smoke tests