validate OIDC authorize form's client_id parameter does not contain null byte#4555
Merged
mitchellhenke merged 1 commit intomasterfrom Jan 4, 2021
Merged
Conversation
mitchellhenke
commented
Jan 4, 2021
Contributor
Author
There was a problem hiding this comment.
I was hoping to use validate_client_id, but service_provider gets called in #initialize, so the error occurs before any validations happen.
mitchellhenke
force-pushed
the
mitchellhenke/fix-null-byte-error
branch
from
532c651 to
b8ec53d
Compare
Contributor
|
Quick (non-blocking) thought: Would this be a more widespread issue than just this one lookup? If so, is there a case for broader handling, e.g. Rack middleware? |
Contributor
Author
|
Yeah, I think there's a decent case to be made. I don't think there are any places where a null byte would be allowed? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're returning a 500 if the
client_idparameter contains a null byte: New Relic