LG-3941 Track statistics for letter responses over time#4550
Merged
LG-3941 Track statistics for letter responses over time#4550
Conversation
zachmargolis
reviewed
Jan 4, 2021
app/services/db/usps_confirmation_code/letters_sent_and_verified_since.rb
Outdated
Show resolved
Hide resolved
app/services/db/usps_confirmation_code/letters_sent_and_verified_since.rb
Outdated
Show resolved
Hide resolved
Comment on lines
+24
to
+26
| [7, 14, 30, 60, 90, 10_000].each do |days_ago| | ||
| sent = letters_sent_since(days_ago) | ||
| validated = letters_sent_and_validated_since(days_ago) |
Contributor
There was a problem hiding this comment.
this is 6 x 2 = 12 table scans of the usps_confirmation_codes table, would it make sense to see if we can parameterize some of this and make one aggregate query? It might be some gnarly CASE statements
Contributor
Author
There was a problem hiding this comment.
i could do a one pass but the usps_confirmation_codes table currently has a few thousand rows. it would need to get several orders of magnitude bigger before it ever took longer than a sub second total.
esparta
reviewed
Jan 4, 2021
mitchellhenke
approved these changes
Jan 6, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.