Skip to content

LG-3756: Upgrade remaining outdated package.json dependencies#4542

Merged
aduth merged 1 commit intomasterfrom
aduth-lg-3756-bump-dependencies
Dec 29, 2020
Merged

LG-3756: Upgrade remaining outdated package.json dependencies#4542
aduth merged 1 commit intomasterfrom
aduth-lg-3756-bump-dependencies

Conversation

@aduth
Copy link
Contributor

@aduth aduth commented Dec 29, 2020

Why: As a user, I want login.gov to not have unused or out of date apps, so that I can use the fastest and most secure app possible

Upgrades last of dependencies targeted for upgrade: Those which involve major version upgrades, or have been updated since previous pass at version updates.

Specifics:

clipboard

Not included:

$ ncu

 basscss-sass       ^3.0.0  →  ^4.0.0   
 source-map-loader  ^1.1.3  →  ^2.0.0   

Run ncu -u to upgrade package.json

**Why**: As a user, I want login.gov to not have unused or out of date apps, so that I can use the fastest and most secure app possible

Upgrades last of dependencies targeted for upgrade: Those which involve major version upgrades, or have been updated since previous pass at version updates.

Specifics:

clipboard
- Changelog: https://github.com/zenorocha/clipboard.js/releases
  - Of note: Constructor changed. Likely not necessary revision in our code, though reduces likelihood of conflict or confusion.
- Testing: Verify "Copy" button on "Add an authentication app" works

Not included:
- basscss-scss: Planned for removal
- source-map-loader: Breaking change involves minimum peer dependency on webpack@5, blocked by yet-unreleased webpacker@6 ("2021-TBD")
  - See: https://github.com/rails/webpacker/blob/master/CHANGELOG.md
Copy link
Contributor

@zachmargolis zachmargolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aduth aduth merged commit b7298bc into master Dec 29, 2020
@aduth aduth deleted the aduth-lg-3756-bump-dependencies branch December 29, 2020 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants