Skip to content

Remove hint.css TOTP informational tooltip#4535

Merged
aduth merged 1 commit intomasterfrom
aduth-rm-hint-css
Dec 28, 2020
Merged

Remove hint.css TOTP informational tooltip#4535
aduth merged 1 commit intomasterfrom
aduth-rm-hint-css

Conversation

@aduth
Copy link
Contributor

@aduth aduth commented Dec 28, 2020

Supersedes #4529
Related Slack discussion: https://gsa-tts.slack.com/archives/CEUQ9FXNJ/p1608744425483200

Why:

  • It is currently broken, displaying as non-visible except by cursor hover or keyboard focus.
  • It's the only instance of a tooltip in the entire application.
  • Tooltips are not ideal for longer-form content like the informational text we show in this tooltip
  • We are not space-constrained on this page and could show informational text as part of the primary content
  • Fewer dependencies for us to manage
  • Less styles for the user to download (faster load time)

**Why**:

- It is currently broken, displaying as non-visible except by cursor hover or keyboard focus.
- It's the only instance of a tooltip in the entire application.
- Tooltips are not ideal for longer-form content like the informational text we show in this tooltip
  - See: https://designsystem.digital.gov/components/tooltip/
- We are not space-constrained on this page and could show informational text as part of the primary content
- Fewer dependencies for us to manage
  - If we were to want tooltips, we should ideally be using USWDS tooltips (see #4529) to consolidate dependencies
- Less styles for the user to download (faster load time)
Copy link
Contributor

@mitchellhenke mitchellhenke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼 👍🏼

Copy link
Contributor

@zachmargolis zachmargolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aduth aduth merged commit 533ef30 into master Dec 28, 2020
@aduth aduth deleted the aduth-rm-hint-css branch December 28, 2020 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants