LG-3756: Bump NPM packages with minor version outdated#4534
Merged
Conversation
aduth
force-pushed
the
aduth-bump-minor-pkg
branch
from
7ee5ded to
143348f
Compare
mitchellhenke
approved these changes
Dec 28, 2020
yarn.lock
Outdated
Contributor
There was a problem hiding this comment.
no more dependencies? 😍
Contributor
Author
There was a problem hiding this comment.
no more dependencies? 😍
I think it's one of those cases where the project author mistakenly listed what should have been devDependencies as regular dependencies. At least, I still see minimist defined as a devDependencies of the project (source).
In other words, we probably won't see any direct benefit to runtime bundle size. But from a developer's perspective, we're downloading a bit less when we run yarn install.
aduth
force-pushed
the
aduth-bump-minor-pkg
branch
from
143348f to
ee268ab
Compare
**Why**: As a user, I want login.gov to not have unused or out of date apps, so that I can use the fastest and most secure app possible. Lower-risk than bumping major packages, which may warrant updates in individualized pull requests. Excludes `hint.css` as this will be addressed separately, either by using USWDS (#4529) or removing tooltips altogether. Specifics: cleave.js - Changelog: https://github.com/nosir/cleave.js/releases - Testing: Check that auto-formatted fields (SSN, TOTP, etc) continue to work as expected focus-trap - Changelog: https://github.com/focus-trap/focus-trap/blob/master/CHANGELOG.md - Testing: Check that session timeout modal and IAL2 Acuant mobile capture continue to trap focus and work as expected libphonenumber-js - Changelog: https://gitlab.com/catamphetamine/libphonenumber-js/-/blob/master/CHANGELOG.md - Testing: Check that phone number validation when adding a phone number continues to validate numbers correctly
aduth
force-pushed
the
aduth-bump-minor-pkg
branch
from
ee268ab to
0838c60
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: As a user, I want login.gov to not have unused or out of date apps, so that I can use the fastest and most secure app possible.
Lower-risk than bumping packages with major-version updates, which may warrant updates in individualized pull requests.
Excludes
hint.cssas this will be addressed separately, either by using USWDS (#4529) or removing tooltips altogether.Specifics:
cleave.js
focus-trap
libphonenumber-js