Add keypair for testing SAML with the 2020 endpoint#4530
Merged
Conversation
orenyk
force-pushed
the
oyk-saml-2020-cert
branch
from
26e1ce1 to
5fa53a7
Compare
mitchellhenke
approved these changes
Dec 30, 2020
Contributor
mitchellhenke
left a comment
mitchellhenke
left a comment
There was a problem hiding this comment.
I don't understand SAML super well, but looks good to me 👍🏼
solipet
approved these changes
Dec 30, 2020
Contributor
solipet
left a comment
solipet
left a comment
There was a problem hiding this comment.
LGTM - are the commands to generate the certificates documented in the handbook anywhere? I'm sure I can recreate the crt but I'm not sure of the top of my head how to generate the encoded version. I gave a quick glance in the handbook and didn't see anything.
Contributor
Author
|
@solipet I just used |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.